AddressSanitizer: use macro to define and declare interceptors for system functions

[samsonov, 2012-02-02 04:36:20]

Re-sending a patch with a fixed llvm-commits address.

>
> Please review this at
http://codereview.appspot.com/**5609049/<http://codereview.appspot.com/5609049/>
>
> Affected files:
>  M     asan_interceptors.cc
>  M     asan_interceptors.h
>  M     asan_mac.cc
>  M     asan_mac.h
>  M     asan_malloc_linux.cc
>
>
--
Alexey Samsonov
Software Engineer, Moscow
samsonov@google.com

[kcc, 2012-02-02 06:52:55]

Looks good! 
(there is no functional change, right?)

[kcc1, 2012-02-02 06:53:55]

Looks good!

--kcc

On Wed, Feb 1, 2012 at 8:36 PM, Alexey Samsonov <samsonov@google.com> wrote:

> Re-sending a patch with a fixed llvm-commits address.
>
>>
>> Please review this at
http://codereview.appspot.com/**5609049/<http://codereview.appspot.com/5609049/>
>>
>> Affected files:
>>  M     asan_interceptors.cc
>>  M     asan_interceptors.h
>>  M     asan_mac.cc
>>  M     asan_mac.h
>>  M     asan_malloc_linux.cc
>>
>>
> --
> Alexey Samsonov
> Software Engineer, Moscow
> samsonov@google.com
>
>

[samsonov, 2012-02-02 07:02:14]

On 2012/02/02 06:52:55, kcc wrote:
> Looks good! 
> (there is no functional change, right?)

Yes, there's no change. I'll wait for glider's opinion then.

[ramosian.glider, 2012-02-02 07:34:10]

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.cc#newcode486
asan_interceptors.cc:486: INTERCEPTOR(char*, strcpy, char *to, const char *from)
{  // NOLINT
Do you still need NOLINT here?

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.h
File asan_interceptors.h (right):

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.h#newcode26
asan_interceptors.h:26: // you want to use it in other parts of RTL, you'll need
to
either add a colon after "to", or remove it from other places.

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.h#newcode66
asan_interceptors.h:66: FUNC_TYPE(func) REAL(func); \
Do you need DEFINE_REAL? Looks like DECLARE_REAL covers all the possible use
cases.

http://codereview.appspot.com/5609049/diff/1/asan_mac.cc
File asan_mac.cc (right):

http://codereview.appspot.com/5609049/diff/1/asan_mac.cc#newcode464
asan_mac.cc:464: dispatch_queue_t dq, void *ctxt,
Please make sure the indentations are correct. I think they are not now.

http://codereview.appspot.com/5609049/diff/1/asan_mac.h
File asan_mac.h (right):

http://codereview.appspot.com/5609049/diff/1/asan_mac.h#newcode59
asan_mac.h:59: CFAllocatorRef alloc,
Mind the indentation.

[samsonov, 2012-02-02 09:55:23]

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.cc#newcode486
asan_interceptors.cc:486: INTERCEPTOR(char*, strcpy, char *to, const char *from)
{  // NOLINT
On 2012/02/02 07:34:10, ramosian.glider wrote:
> Do you still need NOLINT here?
Yes, lint suggests to replace strcpy with snprintf otherwise.

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.h
File asan_interceptors.h (right):

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.h#newcode26
asan_interceptors.h:26: // you want to use it in other parts of RTL, you'll need
to
On 2012/02/02 07:34:10, ramosian.glider wrote:
> either add a colon after "to", or remove it from other places.

Done.

http://codereview.appspot.com/5609049/diff/1/asan_interceptors.h#newcode66
asan_interceptors.h:66: FUNC_TYPE(func) REAL(func); \
On 2012/02/02 07:34:10, ramosian.glider wrote:
> Do you need DEFINE_REAL? Looks like DECLARE_REAL covers all the possible use
> cases.

Added the comment, and removed one of its two usages. I'll leave it here, since
it's present in INTERCEPTOR body.

http://codereview.appspot.com/5609049/diff/1/asan_mac.cc
File asan_mac.cc (right):

http://codereview.appspot.com/5609049/diff/1/asan_mac.cc#newcode464
asan_mac.cc:464: dispatch_queue_t dq, void *ctxt,
On 2012/02/02 07:34:10, ramosian.glider wrote:
> Please make sure the indentations are correct. I think they are not now.

Done.

http://codereview.appspot.com/5609049/diff/1/asan_mac.h
File asan_mac.h (right):

http://codereview.appspot.com/5609049/diff/1/asan_mac.h#newcode59
asan_mac.h:59: CFAllocatorRef alloc,
On 2012/02/02 07:34:10, ramosian.glider wrote:
> Mind the indentation.

Done (need to separate function name and arguments somehow).

[ramosian.glider, 2012-02-02 10:20:08]

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.cc#newcode262
asan_interceptors.cc:262: const pthread_attr_t *attr,
Indentation here

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.cc#newcode279
asan_interceptors.cc:279: struct sigaction *oldact) {
Indentation.

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.h
File asan_interceptors.h (right):

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.h#newcode88
asan_interceptors.h:88: struct sigaction *oldact);
Mind the indentation.

http://codereview.appspot.com/5609049/diff/9001/asan_mac.h
File asan_mac.h (right):

http://codereview.appspot.com/5609049/diff/9001/asan_mac.h#newcode45
asan_mac.h:45: dispatch_queue_t dq,
Indentation here and below.

[ramosian.glider, 2012-02-02 10:20:18]

LGTM otherwise.

[samsonov, 2012-02-02 10:44:24]

r149602

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.cc#newcode262
asan_interceptors.cc:262: const pthread_attr_t *attr,
On 2012/02/02 10:20:08, ramosian.glider wrote:
> Indentation here

Done.

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.cc#newcode279
asan_interceptors.cc:279: struct sigaction *oldact) {
On 2012/02/02 10:20:08, ramosian.glider wrote:
> Indentation.

Done.

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.h
File asan_interceptors.h (right):

http://codereview.appspot.com/5609049/diff/9001/asan_interceptors.h#newcode88
asan_interceptors.h:88: struct sigaction *oldact);
On 2012/02/02 10:20:08, ramosian.glider wrote:
> Mind the indentation.

Done.

http://codereview.appspot.com/5609049/diff/9001/asan_mac.h
File asan_mac.h (right):

http://codereview.appspot.com/5609049/diff/9001/asan_mac.h#newcode45
asan_mac.h:45: dispatch_queue_t dq,
On 2012/02/02 10:20:08, ramosian.glider wrote:
> Indentation here and below.

Done.