Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 5606057: code review 5606057: go/scanner: idiomatic receiver names (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by gri
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/scanner: idiomatic receiver names

Patch Set 1 #

Patch Set 2 : diff -r 20324e413be7 https://code.google.com/p/go #

Patch Set 3 : diff -r 9e24a25b956e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -225 lines) Patch
M src/pkg/go/scanner/scanner.go View 12 chunks +225 lines, -225 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
13 years, 5 months ago (2012-02-02 23:31:04 UTC) #1
rsc
LGTM
13 years, 5 months ago (2012-02-03 00:37:11 UTC) #2
gri
13 years, 5 months ago (2012-02-03 00:42:31 UTC) #3
*** Submitted as b5548669fc39 ***

go/scanner: idiomatic receiver names

R=rsc
CC=golang-dev
http://codereview.appspot.com/5606057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b