Issue 5605045: code review 5605045: cmd/go: improvements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5605045: code review 5605045: cmd/go: improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/go: improvements Do not treat $GOROOT/src/pkg, $GOROOT/src/cmd, $GOPATH/src as package directories (only subdirectories of those can be package directories). Fixes issue 2602. Accept additional compiler and linker arguments during cgo from $CGO_CFLAGS and $CGO_LDFLAGS, as the Makefiles used to do. Show failed pkg-config output. Fixes issue 2785. Use different (perhaps better) git commands. Fixes issue 2109.

Patch Set 1 #

Patch Set 2 : diff -r 7c7af26c2f14 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8086d3ade5ca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8086d3ade5ca https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 5c5b82e6abc5 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -23 lines)			Patch
M	src/cmd/go/build.go	View	1 2 3	2 chunks	+13 lines, -4 lines	0 comments	Download
M	src/cmd/go/get.go	View	1 2	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/cmd/go/main.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/go/vcs.go	View	1 2 3 4	5 chunks	+14 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-31 22:31:32 UTC) #1

rsc

13 years, 5 months ago (2012-01-31 22:40:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5d852698cb0f ***

cmd/go: improvements

Do not treat $GOROOT/src/pkg, $GOROOT/src/cmd,
$GOPATH/src as package directories (only subdirectories
of those can be package directories).  Fixes issue 2602.

Accept additional compiler and linker arguments during
cgo from $CGO_CFLAGS and $CGO_LDFLAGS, as the
Makefiles used to do.

Show failed pkg-config output.  Fixes issue 2785.

Use different (perhaps better) git commands.  Fixes issue 2109.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5605045

Expand All Messages | Collapse All Messages