code review 5604046: go/doc: added error, rune to list of predeclared types

go/doc: added error, rune to list of predeclared types

Don't throw away factory functions returning error or rune.

Fixes issue 2820.

[gri, 2012-01-31 21:25:59]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2012-01-31 21:30:07]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-31 21:33:34]

LGTM but I think there is another bug.

$ ls
x.go
$ cat x.go
package p
type myInt int
func F() myInt
$ godoc .
PACKAGE

package p
    import "."


$

Even though F is kind of a factory for myInt,
F is exported, so it should show up.
Maybe there should also be logic that an
exported function cannot be a factory
for an unexported type?

Russ

[gri, 2012-01-31 23:40:49]

On Tue, Jan 31, 2012 at 1:33 PM, Russ Cox <rsc@golang.org> wrote:
> LGTM but I think there is another bug.

agreed. still contemplating the best way to fix that. submitting this for now.
- gri

>
> $ ls
> x.go
> $ cat x.go
> package p
> type myInt int
> func F() myInt
> $ godoc .
> PACKAGE
>
> package p
>    import "."
>
>
> $
>
> Even though F is kind of a factory for myInt,
> F is exported, so it should show up.
> Maybe there should also be logic that an
> exported function cannot be a factory
> for an unexported type?
>
> Russ

[gri, 2012-01-31 23:41:26]

*** Submitted as bf0e4ba3949d ***

go/doc: added error, rune to list of predeclared types

Don't throw away factory functions returning error or rune.

Fixes issue 2820.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5604046