Issue 5602043: code review 5602043: net/http: close client fd sooner on response read error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5602043: code review 5602043: net/http: close client fd sooner on response read error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by bradfitz

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http: close client fd sooner on response read error This fixes some test noise in TestStressSurpriseServerCloses when ulimit -n something low, like 256 on a Mac. Previously, when the server closed on us and we were expecting more responses (like we are in that test), we'd read an "Unexpected EOF" and just forget about the client's net.Conn. Now it's closed, rather than waiting on the finalizer to release the fd.

Patch Set 1 #

Patch Set 2 : diff -r f2167956d923 https://go.googlecode.com/hg #

Patch Set 3 : diff -r f2167956d923 https://go.googlecode.com/hg #

Patch Set 4 : diff -r e3df693ee667 https://go.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pkg/net/http/transport.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 5 months ago (2012-01-31 17:39:19 UTC) #1

bradfitz

13 years, 5 months ago (2012-01-31 17:45:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e7f919814232 ***

net/http: close client fd sooner on response read error

This fixes some test noise in TestStressSurpriseServerCloses when
ulimit -n something low, like 256 on a Mac.

Previously, when the server closed on us and we were expecting more
responses (like we are in that test), we'd read an "Unexpected EOF"
and just forget about the client's net.Conn.  Now it's closed,
rather than waiting on the finalizer to release the fd.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5602043

Expand All Messages | Collapse All Messages