Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 5600053: code review 5600053: runtime: fix mkasmh.sh for arm? (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: fix mkasmh.sh for arm? The builder is Debian, so maybe running dash, the shell that time forgot.

Patch Set 1 #

Patch Set 2 : diff -r 72133bb4e451 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 72133bb4e451 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 72133bb4e451 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/mkasmh.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 5 months ago (2012-01-31 04:03:12 UTC) #1
r
LGTM sure, why not
13 years, 5 months ago (2012-01-31 04:16:16 UTC) #2
rsc
13 years, 5 months ago (2012-01-31 04:17:12 UTC) #3
*** Submitted as 5707c93b1488 ***

runtime: fix mkasmh.sh for arm?

The builder is Debian, so maybe running dash,
the shell that time forgot.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5600053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b