code review 5600048: go: improvements

go: improvements

Add 'go clean'.
Make 'go build' write to pkgname, not a.out.
Make 'go test -c' write to pkgname.test, not test.out.
Make 'go install' write alternate binaries to .../bin/goos_goarch/.

[rsc, 2012-01-31 04:22:06]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2012-01-31 04:25:15]

Sorry, the removed Makefile belongs in 5601057.
Will move.

[r, 2012-01-31 04:28:24]

LGTM

[rsc, 2012-01-31 04:42:40]

*** Submitted as b479bc080ad9 ***

go: improvements

Add 'go clean'.
Make 'go build' write to pkgname, not a.out.
Make 'go test -c' write to pkgname.test, not test.out.
Make 'go install' write alternate binaries to .../bin/goos_goarch/.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5600048

[rog, 2012-01-31 08:57:04]

i was mildly surprised to see that "go clean x" doesn't remove
the installed package binaries for x.

On 31 January 2012 04:22,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go: improvements
>
> Add 'go clean'.
> Make 'go build' write to pkgname, not a.out.
> Make 'go test -c' write to pkgname.test, not test.out.
> Make 'go install' write alternate binaries to .../bin/goos_goarch/.
>
> Please review this at http://codereview.appspot.com/5600048/
>
> Affected files:
>  R src/cmd/go/Makefile
>  M src/cmd/go/build.go
>  A src/cmd/go/clean.go
>  M src/cmd/go/doc.go
>  M src/cmd/go/main.go
>  M src/cmd/go/pkg.go
>  M src/cmd/go/test.go
>  M src/cmd/go/testflag.go
>
>

[bsiegert, 2012-01-31 14:56:56]

On Tue, Jan 31, 2012 at 09:57, roger peppe <rogpeppe@gmail.com> wrote:
> i was mildly surprised to see that "go clean x" doesn't remove
> the installed package binaries for x.

It's "clean", not "uninstall".

--Benny.

[rsc, 2012-01-31 15:01:22]

On Tue, Jan 31, 2012 at 03:57, roger peppe <rogpeppe@gmail.com> wrote:
> i was mildly surprised to see that "go clean x" doesn't remove
> the installed package binaries for x.

make clean never did.

[rog, 2012-01-31 15:47:44]

On 31 January 2012 15:01, Russ Cox <rsc@golang.org> wrote:
> On Tue, Jan 31, 2012 at 03:57, roger peppe <rogpeppe@gmail.com> wrote:
>> i was mildly surprised to see that "go clean x" doesn't remove
>> the installed package binaries for x.
>
> make clean never did.

yes that's true.

now that go install builds stuff recursively by default,
the installed status (or not) of a package feels much
less important - the files in $GOPATH/pkg feel
akin to the temporary files created by make in a package's
directory - they're just a cache, and it's useful to
be able to clean caches.

that's probably the wrong way to look at it, but i
think that's why i felt surprised.

[rsc, 2012-01-31 15:49:27]

> yes that's true.
>
> now that go install builds stuff recursively by default,
> the installed status (or not) of a package feels much
> less important - the files in $GOPATH/pkg feel
> akin to the temporary files created by make in a package's
> directory - they're just a cache, and it's useful to
> be able to clean caches.
>
> that's probably the wrong way to look at it, but i
> think that's why i felt surprised.

go clean is intended as the opposite of go build,
and in that light i think it fits perfectly.
if you want to be the opposite of go install,
you can use go clean -i, or if you are feeling
particularly aggressive, go clean -i -r.
it's not really tenable to be exactly 1:1.