Issue 5599054: code review 5599054: syscall: cache environment variables on Plan 9.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5599054: code review 5599054: syscall: cache environment variables on Plan 9. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by ality

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

syscall: cache environment variables on Plan 9. This can drastically reduce the number of system calls made by programs that repeatedly query the environment.

Patch Set 1 #

Patch Set 2 : diff -r e3cbb4364149 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e3cbb4364149 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3d6b42778a90 https://code.google.com/p/go/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -42 lines)			Patch
	M	src/pkg/syscall/env_plan9.go	View	1	1 chunk	+96 lines, -42 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 9 months ago (2012-01-31 13:10:31 UTC) #1

ality

13 years, 9 months ago (2012-02-01 02:14:08 UTC) #3

*** Submitted as 82ecd6cd5141 ***

syscall: cache environment variables on Plan 9.

This can drastically reduce the number of system
calls made by programs that repeatedly query the
environment.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5599054

Expand All Messages | Collapse All Messages