code review 5599047: build: fix buildscript breakage after all.bash

build: fix buildscript breakage after all.bash

Fix from Russ. Tested that multiple builds in a row
work again.

[bradfitz, 2012-01-30 19:58:05]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc1, 2012-01-30 20:00:59]

sorry for the runaround

http://codereview.appspot.com/5599047/diff/2016/src/buildscript.sh
File src/buildscript.sh (right):

http://codereview.appspot.com/5599047/diff/2016/src/buildscript.sh#newcode38
src/buildscript.sh:38: s/go_bootstrap-tool/go-tool/g
add
s;"\$GOBIN"/go-tool;"$GOROOT"/bin/go-tool;g

http://codereview.appspot.com/5599047/diff/2016/src/buildscript/darwin_386.sh
File src/buildscript/darwin_386.sh (right):

http://codereview.appspot.com/5599047/diff/2016/src/buildscript/darwin_386.sh...
src/buildscript/darwin_386.sh:67: "$GOBIN"/go-tool/pack grc "$WORK"/runtime.a
"$WORK"/runtime/_obj/_go_.8 "$WORK"/runtime/_obj/alg.8
"$WORK"/runtime/_obj/atomic_386.8 "$WORK"/runtime/_obj/cgocall.8
"$WORK"/runtime/_obj/chan.8 "$WORK"/runtime/_obj/closure_386.8
"$WORK"/runtime/_obj/complex.8 "$WORK"/runtime/_obj/cpuprof.8
"$WORK"/runtime/_obj/float.8 "$WORK"/runtime/_obj/hashmap.8
"$WORK"/runtime/_obj/iface.8 "$WORK"/runtime/_obj/lock_sema.8
"$WORK"/runtime/_obj/mcache.8 "$WORK"/runtime/_obj/mcentral.8
"$WORK"/runtime/_obj/mem_darwin.8 "$WORK"/runtime/_obj/mfinal.8
"$WORK"/runtime/_obj/mfixalloc.8 "$WORK"/runtime/_obj/mgc0.8
"$WORK"/runtime/_obj/mheap.8 "$WORK"/runtime/_obj/msize.8
"$WORK"/runtime/_obj/print.8 "$WORK"/runtime/_obj/proc.8
"$WORK"/runtime/_obj/rune.8 "$WORK"/runtime/_obj/runtime.8
"$WORK"/runtime/_obj/signal_darwin_386.8 "$WORK"/runtime/_obj/slice.8
"$WORK"/runtime/_obj/symtab.8 "$WORK"/runtime/_obj/thread_darwin.8
"$WORK"/runtime/_obj/traceback_x86.8 "$WORK"/runtime/_obj/vlrt_386.8
"$WORK"/runtime/_obj/zmalloc_386.8 "$WORK"/runtime/_obj/zmprof_386.8
"$WORK"/runtime/_obj/zruntime1_386.8 "$WORK"/runtime/_obj/zsema_386.8
"$WORK"/runtime/_obj/zsigqueue_386.8 "$WORK"/runtime/_obj/zstring_386.8
"$WORK"/runtime/_obj/ztime_386.8 "$WORK"/runtime/_obj/asm_386.8
"$WORK"/runtime/_obj/memmove_386.8 "$WORK"/runtime/_obj/rt0_darwin_386.8
"$WORK"/runtime/_obj/sys_darwin_386.8 "$WORK"/runtime/_obj/vlop_386.8
This needs to continue to say $GOROOT/bin/go-tool, not $GOBIN.  When those are
different, we really do mean the former.

[bradfitz, 2012-01-30 20:05:22]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2012-01-30 20:06:44]

LGTM

[bradfitz, 2012-01-30 20:08:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=a5e253d9abdc ***

build: fix buildscript breakage after all.bash

Fix from Russ. Tested that multiple builds in a row
work again.

R=rsc, rsc
CC=golang-dev
http://codereview.appspot.com/5599047