Issue 5599046: code review 5599046: runtime: Update hash functions to use a hidden seed ins...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5599046: code review 5599046: runtime: Update hash functions to use a hidden seed ins... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dgryski

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: Update hash functions to use a hidden seed instead of 0. This patch adds a hash seed to the Hmap struct. Each seed is initialized by runtime.fastrand1(). This is the first step of a solution to issue 2630. Fastrand1 still needs to be updated to provide us with actually random bits.

Patch Set 1 #

Patch Set 2 : diff -r 50c95c1dfa5b http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0700956e0077 http://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/pkg/runtime/hashmap.c	View	1	5 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dgryski

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/

13 years, 3 months ago (2012-01-30 19:28:57 UTC) #1

rsc

13 years, 3 months ago (2012-01-31 05:37:02 UTC) #3

*** Submitted as 18b283fbffae ***

runtime: use per-map hash seeds

This patch adds a hash seed to the Hmap struct.  Each seed is
initialized by runtime.fastrand1().  This is the first step of a
solution to issue 2630.  Fastrand1 still needs to be updated to provide
us with actually random bits.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5599046

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages