Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(211)

Issue 5598049: code review 5598049: go: move compilers into the go-tool directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by r
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go: move compilers into the go-tool directory Also delete gotest, since it's messy to fix and slated for deletion anyway. A couple of things outside src can't be tested any more. "go test" will be fixed and these tests will be re-enabled. They're noisy for now. Fixes issue 284.

Patch Set 1 #

Patch Set 2 : diff -r dc7f79145d28 https://code.google.com/p/go #

Patch Set 3 : diff -r dc7f79145d28 https://code.google.com/p/go #

Patch Set 4 : diff -r 57dc72e2123f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1548 lines, -2391 lines) Patch
M misc/cgo/test/Makefile View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/Make.cmd View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/Make.inc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/Make.pkg View 1 2 chunks +4 lines, -9 lines 0 comments Download
M src/Make.tool View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/buildscript/darwin_386.sh View 1 40 chunks +107 lines, -107 lines 0 comments Download
M src/buildscript/darwin_amd64.sh View 1 40 chunks +106 lines, -106 lines 0 comments Download
M src/buildscript/freebsd_386.sh View 1 40 chunks +107 lines, -107 lines 0 comments Download
M src/buildscript/freebsd_amd64.sh View 1 40 chunks +106 lines, -106 lines 0 comments Download
M src/buildscript/linux_386.sh View 1 40 chunks +107 lines, -107 lines 0 comments Download
M src/buildscript/linux_amd64.sh View 1 40 chunks +106 lines, -106 lines 0 comments Download
M src/buildscript/linux_arm.sh View 1 40 chunks +110 lines, -110 lines 0 comments Download
M src/buildscript/netbsd_386.sh View 1 40 chunks +107 lines, -107 lines 0 comments Download
M src/buildscript/netbsd_amd64.sh View 1 40 chunks +106 lines, -106 lines 0 comments Download
M src/buildscript/openbsd_386.sh View 1 40 chunks +107 lines, -107 lines 0 comments Download
M src/buildscript/openbsd_amd64.sh View 1 40 chunks +106 lines, -106 lines 0 comments Download
M src/buildscript/plan9_386.sh View 1 40 chunks +107 lines, -107 lines 0 comments Download
M src/buildscript/windows_386.sh View 1 40 chunks +109 lines, -109 lines 0 comments Download
M src/buildscript/windows_amd64.sh View 1 40 chunks +108 lines, -108 lines 0 comments Download
M src/cmd/5a/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5c/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5g/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5l/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6a/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6c/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6g/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6l/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8a/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8c/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8g/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8l/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/Makefile View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/go/build.go View 1 3 chunks +8 lines, -4 lines 0 comments Download
R src/cmd/gomake/doc.go View 1 1 chunk +0 lines, -36 lines 0 comments Download
R src/cmd/gotest/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/cmd/gotest/doc.go View 1 1 chunk +0 lines, -139 lines 0 comments Download
R src/cmd/gotest/flag.go View 1 1 chunk +0 lines, -165 lines 0 comments Download
R src/cmd/gotest/gotest.go View 1 1 chunk +0 lines, -464 lines 0 comments Download
M src/env.bash View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/Makefile View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/exp/types/gcimporter_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mkasmh.sh View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/pkg/runtime/mkgodefs.sh View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/run.bash View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/bench/go1/Makefile View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/run View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
13 years, 5 months ago (2012-01-30 22:39:29 UTC) #1
rsc1
LGTM
13 years, 5 months ago (2012-01-30 22:45:15 UTC) #2
r
13 years, 5 months ago (2012-01-30 22:46:34 UTC) #3
*** Submitted as dcbd5d0762b2 ***

go: move compilers into the go-tool directory
Also delete gotest, since it's messy to fix and slated for deletion anyway.
A couple of things outside src can't be tested any more. "go test" will be
fixed and these tests will be re-enabled. They're noisy for now.

Fixes issue 284.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5598049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b