Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(744)

Issue 5596044: Extra Anaglyph Modes for BGE

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dfelinto
Modified:
12 years, 2 months ago
Reviewers:
art4med, ideasman42, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch adds a "glass colour" enum to the Anaglyph stereo interface. Now Red-Cyan is the default, but it supports too green-magenta (I never saw one of those but I know they are out there) and magenta-green. I ordered a magenta-green glass for a project that should arrive next week. Once I test this patch with the real thing I will try to push it to a commit (despite our lovely bcon3 feature freeze status). As for the patch: 1) it can/should probably initialize anaglyphmode in scene.c (blenkernel) but the default is 0 (red-cyan) so I don't know if it's necessary. 2) instead of creating new RAS_ defines I hardcoded the values. I'm one to point fingers when people do that but it sounds a bit overkill for this case. Thoughts? 3) I have a version of this patch that supports setting it through python. It works nice but I may be the only person that needs that changing in realtime :) so I'm not including this in the patch.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
release/scripts/startup/bl_ui/properties_game.py View 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/makesdna/DNA_scene_types.h View 2 chunks +8 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_scene.c View 2 chunks +12 lines, -0 lines 0 comments Download
source/gameengine/BlenderRoutines/BL_KetsjiEmbedStart.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
source/gameengine/GamePlayer/ghost/GPG_Application.cpp View 1 chunk +2 lines, -1 line 0 comments Download
source/gameengine/Rasterizer/RAS_IRasterizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_OpenGLRasterizer.h View 2 chunks +4 lines, -0 lines 0 comments Download
source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_OpenGLRasterizer.cpp View 3 chunks +40 lines, -4 lines 0 comments Download

Messages

Total messages: 3
dfelinto
12 years, 3 months ago (2012-01-29 07:53:49 UTC) #1
ideasman42
LGTM
12 years, 3 months ago (2012-01-30 04:45:00 UTC) #2
art4med
12 years, 2 months ago (2012-03-06 18:50:35 UTC) #3
On 2012/01/30 04:45:00, ideasman42 wrote:
> LGTM

While you may also want to make available the red/amber pairing, this could be a
post-process.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b