code review 5593049: cgo: print line numbers in fatal errors when relevant.

cgo: print line numbers in fatal errors when relevant.

Signatures of fatalf and error_ helpers have been matched for
consistency.
Fixes issue 1800.

[remyoudompheng, 2012-01-29 11:21:40]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-01-29 11:22:24]

I'm not sure the test should be in test/fixedbugs, but I couldn't find anything
similar in the existing tree.

Rémy.

[remyoudompheng, 2012-01-31 07:16:52]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

Please take another look.

[rsc, 2012-02-06 17:17:48]

Thanks for fixing this.  It looks like the overwhelming case
is that you pass token.NoPos to fatalf; maybe that should
not be a dedicated argument.   Instead, you could write a

func lineno(p token.Pos) string

and then in the places where you need it, start the format
with "%s: " and pass lineno(pos) as the first argument.

This approach has the benefit of leaving fatalf with a signature
that go vet expects, with the format as the first argument.

[remyoudompheng, 2012-02-06 17:36:20]

On 2012/02/06 17:17:48, rsc wrote:
> Thanks for fixing this.  It looks like the overwhelming case
> is that you pass token.NoPos to fatalf; maybe that should
> not be a dedicated argument.   Instead, you could write a
> 
> func lineno(p token.Pos) string
> 
> and then in the places where you need it, start the format
> with "%s: " and pass lineno(pos) as the first argument.
> 
> This approach has the benefit of leaving fatalf with a signature
> that go vet expects, with the format as the first argument.

Indeed, that avoids polluting the diff with unnecessary changes.

Rémy.

[remyoudompheng, 2012-02-06 17:36:37]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[rsc, 2012-02-06 19:01:00]

LGTM

Thanks

[remyoudompheng, 2012-02-06 19:39:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=24ea565d3631 ***

cgo: print line numbers in fatal errors when relevant.

Signatures of fatalf and error_ helpers have been matched for
consistency.
Fixes issue 1800.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/5593049

[lvd, 2012-02-07 10:50:28]

on darwin/amd64, in 2 separate clean clients:

parent: 11749:fae148fab2a7 tip
 flag: describe valid input for Duration flags.
branch: default
commit: (clean)
update: (current)


with bin and pkg wiped before all.bash i end up with:

> =========== fixedbugs/bug408.go
> BUG: errchk: command succeeded unexpectedly
> 
0 known bugs; 1 unexpected bugs; test output differs

although the dashboard looks fine.

[jmhodges, 2012-02-07 11:16:58]

Made an issue for this just earlier tonight:
http://code.google.com/p/go/issues/detail?id=2902

On Tue, Feb 7, 2012 at 2:50 AM,  <lvd@google.com> wrote:
> on darwin/amd64, in 2 separate clean clients:
>
> parent: 11749:fae148fab2a7 tip
>  flag: describe valid input for Duration flags.
> branch: default
> commit: (clean)
> update: (current)
>
>
> with bin and pkg wiped before all.bash i end up with:
>
>> =========== fixedbugs/bug408.go
>> BUG: errchk: command succeeded unexpectedly
>
>
> 0 known bugs; 1 unexpected bugs; test output differs
>
> although the dashboard looks fine.
>
>
>
> http://codereview.appspot.com/5593049/