code review 5593047: go: record location of failed imports for error reporting.

go: record location of failed imports for error reporting.

Fixes issue 2664.

[remyoudompheng, 2012-01-28 17:33:59]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-01-28 17:38:22]

On 2012/01/28 17:33:59, remyoudompheng wrote:
> I'd like you to review this change to
> https://go.googlecode.com/hg/

It includes an API change for go/build. Maybe Russ has a better idea.

Rémy.

[rsc, 2012-01-31 19:25:35]

Thanks for working on this.

I agree that go/build needs to change a little to really fix this.
Can you make the new fields map[string][]token.Position,
and record all the imports of a given package instead of just
one of them?

In the cmd/go tool it would be fine to consult and print
just the first position, but in the long term we might want
to expand that or change what gets printed, and it is helpful
to be able to show all the locations.

Thanks.
Russ

[remyoudompheng, 2012-01-31 22:02:39]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[rsc, 2012-01-31 22:06:37]

LGTM

I thought I would be able to resist, but I can't.
Please change (Test)ImportsPos to (Test)ImportPos,
since it is the position of a single import.

[remyoudompheng, 2012-01-31 22:19:26]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[rsc, 2012-01-31 22:27:47]

LGTM

Thanks very much.

[remyoudompheng, 2012-01-31 22:37:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=5c5b82e6abc5 ***

go: record location of failed imports for error reporting.

Fixes issue 2664.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/5593047