Issue 5592045: code review 5592045: crypto/elliptic: p224Contract could produce a non-minim...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5592045: code review 5592045: crypto/elliptic: p224Contract could produce a non-minim... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by agl1

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/elliptic: p224Contract could produce a non-minimal representation. I missed an overflow in contract because I suspected that the prime elimination would take care of it. It didn't, and I forgot to get back to the overflow. Because of this, p224Contract may have produced a non-minimal representation, causing flakey failures ~0.02% of the time.

Patch Set 1 #

Patch Set 2 : diff -r c66dbb0415cc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c66dbb0415cc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e92908c9c87d https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	src/pkg/crypto/elliptic/elliptic_test.go	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
	M	src/pkg/crypto/elliptic/p224.go	View	1	2 chunks	+34 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-01-31 16:22:15 UTC) #1

agl1

13 years, 4 months ago (2012-01-31 17:27:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9b73a54857c3 ***

crypto/elliptic: p224Contract could produce a non-minimal representation.

I missed an overflow in contract because I suspected that the prime
elimination would take care of it. It didn't, and I forgot to get back
to the overflow. Because of this, p224Contract may have produced a
non-minimal representation, causing flakey failures ~0.02% of the
time.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5592045

Expand All Messages | Collapse All Messages