code review 5591045: cmd/go: improvements

cmd/go: improvements

Print build errors to stderr during 'go run'.
Stream test output during 'go test' (no args).  Fixes issue 2731.
Add go test -i to install test dependencies.  Fixes issue 2685.
Fix data race in exitStatus.  Fixes issue 2709.
Fix tool paths.  Fixes issue 2817.

[rsc, 2012-01-31 18:02:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-01-31 18:02:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-01-31 18:09:32]

http://codereview.appspot.com/5591045/diff/7001/src/cmd/go/test.go
File src/cmd/go/test.go (right):

http://codereview.appspot.com/5591045/diff/7001/src/cmd/go/test.go#newcode223
src/cmd/go/test.go:223: testStreamOutput = len(pkgs) == 0 || testBench
why not len(pkgs) <= 1 || testBench

?

If I do:

go test net/http

.. from $GOROOT or $GOROOT/src, can't that also stream safely?

http://codereview.appspot.com/5591045/diff/7001/src/cmd/go/test.go#newcode241
src/cmd/go/test.go:241: deps := map[string]bool{
is this duplicated somewhere else?

[rsc, 2012-01-31 19:19:55]

On Tue, Jan 31, 2012 at 13:09,  <bradfitz@golang.org> wrote:
> If I do:
> go test net/http
> .. from $GOROOT or $GOROOT/src, can't that also stream safely?

I'm trying to introduce streaming where the behavior
wouldn't change, you're just seeing the output sooner.
go test net/http does not print test output if the test
passes; streaming would change that.  I'd rather not
change the behavior based on the number of arguments
or packages (beyond 0) because then you get different
behavior depending on how many packages a pattern
happens to match, or on how many packages you happen
to be testing.

However, if -v is specified, then you're going to see the
output regardless, so in that case, if there is only one
package, you might as well see the output sooner.
I've added that as a case for streaming.

In order to make this auto-streaming truly not change the
output, I flipped the order shown for a test failure.  Now
the listing always shows the output before the ok/FAIL line.

ok net
ok net/http
<failing output for fcgi>
FAIL net/http/fcgi

> src/cmd/go/test.go:241: deps := map[string]bool{
> is this duplicated somewhere else?

Not exactly, and not in a way that's particularly easy
to factor out.

Russ

[rsc, 2012-01-31 19:20:04]

PTAL

[bradfitz, 2012-01-31 19:26:37]

LGTM

[niemeyer, 2012-01-31 19:28:10]

http://codereview.appspot.com/5591045/diff/7002/src/cmd/go/test.go
File src/cmd/go/test.go (right):

http://codereview.appspot.com/5591045/diff/7002/src/cmd/go/test.go#newcode232
src/cmd/go/test.go:232: testStreamOutput = len(pkgArgs) == 0 || testBench ||
Nice, thanks.

[r, 2012-01-31 19:30:56]

LGTM

[rsc, 2012-01-31 20:08:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=7c7af26c2f14 ***

cmd/go: improvements

Print build errors to stderr during 'go run'.
Stream test output during 'go test' (no args).  Fixes issue 2731.
Add go test -i to install test dependencies.  Fixes issue 2685.
Fix data race in exitStatus.  Fixes issue 2709.
Fix tool paths.  Fixes issue 2817.

R=golang-dev, bradfitz, n13m3y3r, r
CC=golang-dev
http://codereview.appspot.com/5591045