Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 5588048: code review 5588048: net: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
mikio, bradfitz
CC:
golang-dev
Visibility:
Public.

Description

net: fix windows build

Patch Set 1 #

Patch Set 2 : diff -r ab6805d0865a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c66dbb0415cc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/net/fd_windows.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello mikioh (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2012-01-31 16:20:32 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=f2167956d923 *** net: fix windows build TBR=mikioh CC=golang-dev http://codereview.appspot.com/5588048
13 years, 5 months ago (2012-01-31 16:20:38 UTC) #2
bradfitz
LGTM On Tue, Jan 31, 2012 at 8:20 AM, <rsc@golang.org> wrote: > Reviewers: mikioh, > ...
13 years, 5 months ago (2012-01-31 16:21:48 UTC) #3
mikio
13 years, 5 months ago (2012-01-31 16:25:23 UTC) #4
LGTM

oops, thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b