Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(225)

Issue 5581053: code review 5581053: fix: add image/{bmp,tiff} to go1pkgrename. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by nigeltao
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

fix: add image/{bmp,tiff} to go1pkgrename.

Patch Set 1 #

Patch Set 2 : diff -r 05c495f00135 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 05c495f00135 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 67f727f62e0e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/cmd/fix/go1pkgrename.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2012-01-31 00:45:32 UTC) #1
r
LGTM but don't forget the docs
13 years, 5 months ago (2012-01-31 00:51:42 UTC) #2
nigeltao
13 years, 5 months ago (2012-01-31 01:28:04 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=af2510fee422 ***

fix: add image/{bmp,tiff} to go1pkgrename.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5581053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b