Issue 5580047: code review 5580047: compress/flate: undo misuse of skipNever

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5580047: code review 5580047: compress/flate: undo misuse of skipNever (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
imkrasin, golang-dev

Visibility:
Public.

Description

compress/flate: undo misuse of skipNever I assume this was a too aggressive search-and-replace.

Patch Set 1 #

Patch Set 2 : diff -r 2a4a68823b37 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2a4a68823b37 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2a4a68823b37 https://code.google.com/p/go/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/compress/flate/deflate.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello imkrasin@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 5 months ago (2012-01-30 18:22:34 UTC) #1

rsc

13 years, 5 months ago (2012-01-30 18:24:28 UTC) #3

*** Submitted as 18b58e5df703 ***

compress/flate: undo misuse of skipNever

I assume this was a too aggressive search-and-replace.

R=imkrasin
CC=golang-dev
http://codereview.appspot.com/5580047

Expand All Messages | Collapse All Messages