If no title is provided, use ' ' by default instead of erroring out

If no title is provided, use ' ' by default instead of erroring out

[M-A, 2012-01-27 19:46:01]

It annoys a lot of devs that a string is required.

http://codereview.appspot.com/5577063/diff/1/upload.py
File upload.py (right):

http://codereview.appspot.com/5577063/diff/1/upload.py#newcode2251
upload.py:2251: title = title or ' '
It's a more redundant written this way but a bit more readable. I'm open to
other format.

[Andi Albrecht, 2012-01-29 08:50:33]

I assume that the devs are annoyed when uploading a intermediate result of their
work, but not when publishing a changeset for review.

Therefore I would keep the "empty title" check but broaden it to something like
"if title is empty and send_mail flag is set (or issue is new)". Otherwise when
the title is empty we send mails with " (issue 123)" as subject.

http://codereview.appspot.com/5577063/diff/1/upload.py
File upload.py (right):

http://codereview.appspot.com/5577063/diff/1/upload.py#newcode2251
upload.py:2251: title = title or ' '
What about parenthesis?

title = (title or message...
         or raw_input...
         or ' ')

That'd reduce it to a single assignment.

On 2012/01/27 19:46:01, M-A wrote:
> It's a more redundant written this way but a bit more readable. I'm open to
> other format.

[M-A, 2012-01-30 16:03:21]

looks better?

[Andi Albrecht, 2012-01-31 07:07:06]

LGTM