code review 5577062: cmd/go: make vcs command actually gather output

cmd/go: make vcs command actually gather output

[rog, 2012-01-27 12:45:32]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-01-27 16:14:02]

LGTM

On Fri, Jan 27, 2012 at 4:45 AM, <rogpeppe@gmail.com> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/go: make vcs command actually gather output
>
> Please review this at
http://codereview.appspot.com/**5577062/<http://codereview.appspot.com/5577062/>
>
> Affected files:
>  M src/cmd/go/vcs.go
>
>
> Index: src/cmd/go/vcs.go
> ==============================**==============================**=======
> --- a/src/cmd/go/vcs.go
> +++ b/src/cmd/go/vcs.go
> @@ -157,8 +157,8 @@
>        var buf bytes.Buffer
>        cmd.Stdout = &buf
>        cmd.Stderr = &buf
> +       err := cmd.Run()
>        out := buf.Bytes()
> -       err := cmd.Run()
>        if err != nil {
>                fmt.Fprintf(os.Stderr, "# cd %s; %s %s\n", dir, v.cmd,
> strings.Join(args, " "))
>                os.Stderr.Write(out)
>
>
>

[rsc, 2012-01-27 16:21:52]

LGTM

[rog, 2012-01-28 12:02:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=23995c78329e ***

cmd/go: make vcs command actually gather output

R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5577062