code review 5577058: cmd/go: solve ambiguity of get lp.net/project/foo

cmd/go: solve ambiguity of get lp.net/project/foo

This solves the ambiguity for "lp.net/project/foo". In these URLs,
"foo" could be a series name registered in Launchpad with its own
branch, and it could also be the name of a directory within the
main project branch one level up.

Solve it by testing if the series branch exists in Launchpad
and if it doesn't moving the root one level up.

[niemeyer, 2012-01-27 01:59:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc1, 2012-01-27 02:45:48]

LGTM

http://codereview.appspot.com/5577058/diff/2002/src/cmd/go/vcs.go
File src/cmd/go/vcs.go (right):

http://codereview.appspot.com/5577058/diff/2002/src/cmd/go/vcs.go#newcode419
src/cmd/go/vcs.go:419: _, err := httpGET(expand(match,
"https://code.launchpad.net/{project}/{series}/.bzr/branch-format"))
It looks like series already has the / in it, so this would be {project}{series}
not {project}/{series}, right?

[niemeyer, 2012-01-27 02:58:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=c8aa7d51eede ***

cmd/go: solve ambiguity of get lp.net/project/foo

This solves the ambiguity for "lp.net/project/foo". In these URLs,
"foo" could be a series name registered in Launchpad with its own
branch, and it could also be the name of a directory within the
main project branch one level up.

Solve it by testing if the series branch exists in Launchpad
and if it doesn't moving the root one level up.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5577058

[niemeyer, 2012-01-27 02:59:23]

http://codereview.appspot.com/5577058/diff/2002/src/cmd/go/vcs.go
File src/cmd/go/vcs.go (right):

http://codereview.appspot.com/5577058/diff/2002/src/cmd/go/vcs.go#newcode419
src/cmd/go/vcs.go:419: _, err := httpGET(expand(match,
"https://code.launchpad.net/{project}/{series}/.bzr/branch-format"))
On 2012/01/27 02:45:48, rsc1 wrote:
> It looks like series already has the / in it, so this would be
{project}{series}
> not {project}/{series}, right?

Fixed. Thanks.