Issue 5576071: code review 5576071: test: add test of NaN in map

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5576071: code review 5576071: test: add test of NaN in map (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
iant, r, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 54016655b9d7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 54016655b9d7 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 54016655b9d7 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 9eb972982dec https://code.google.com/p/go/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
	M	test/map.go	View	1 2 3 4	4 chunks	+30 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 5 months ago (2012-01-30 16:30:30 UTC) #1

LGTM http://codereview.appspot.com/5576071/diff/3001/test/map.go File test/map.go (right): http://codereview.appspot.com/5576071/diff/3001/test/map.go#newcode663 test/map.go:663: } also check len(m) == 1

13 years, 5 months ago (2012-01-30 17:42:08 UTC) #2

rsc

Hello iant@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2012-01-30 18:19:30 UTC) #3

rsc

13 years, 5 months ago (2012-01-30 18:41:41 UTC) #5

*** Submitted as bb69d3a2a4ee ***

test: add test of NaN in map

R=iant, r
CC=golang-dev
http://codereview.appspot.com/5576071

Expand All Messages | Collapse All Messages