code review 5576068: cmd/goapi: expand embedded interfaces

cmd/goapi: expand embedded interfaces

Fixes issue 2801

[bradfitz, 2012-01-29 18:15:15]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc1, 2012-01-29 18:18:17]

http://codereview.appspot.com/5576068/diff/10/src/cmd/goapi/goapi.go
File src/cmd/goapi/goapi.go (right):

http://codereview.appspot.com/5576068/diff/10/src/cmd/goapi/goapi.go#newcode118
src/cmd/goapi/goapi.go:118: interfaces      map[string]*ast.InterfaceType //
"pkg\0name" -> interface
Really?  \0?
You can use structs as map keys now.

[bradfitz, 2012-01-29 18:44:33]

Right. Old habit.

Will fix.
 On Jan 29, 2012 10:18 AM, <rsc@google.com> wrote:

>
>
http://codereview.appspot.com/**5576068/diff/10/src/cmd/goapi/**goapi.go<http...
> File src/cmd/goapi/goapi.go (right):
>
> http://codereview.appspot.com/**5576068/diff/10/src/cmd/goapi/**
>
goapi.go#newcode118<http://codereview.appspot.com/5576068/diff/10/src/cmd/goapi/goapi.go#newcode118>
> src/cmd/goapi/goapi.go:118: interfaces
> map[string]*ast.InterfaceType // "pkg\0name" -> interface
> Really?  \0?
> You can use structs as map keys now.
>
>
http://codereview.appspot.com/**5576068/<http://codereview.appspot.com/5576068/>
>

[bradfitz, 2012-01-29 21:20:58]

Hello golang-dev@googlegroups.com, rsc@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-01-30 04:43:46]

PTAL?
 On Jan 29, 2012 1:20 PM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com, rsc@google.com (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5576068/<http://codereview.appspot.com/5576068/>
>

[rsc1, 2012-01-30 04:46:36]

LGTM

[bradfitz, 2012-01-30 05:04:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=db35be288dd1 ***

cmd/goapi: expand embedded interfaces

Fixes issue 2801

R=rsc
CC=golang-dev
http://codereview.appspot.com/5576068