code review 5576061: cmd/go: first piece of tool rearrangement

cmd/go: first piece of tool rearrangement
1) create go-tool dir in make.bash
2) clean up stale binaries in make.bash
3) add 'tool' command to go
4) convert goyacc->yacc as a first test tool
Since goyacc stands alone, it's a safe trial.

[r, 2012-01-28 19:01:04]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
/Users/r/go

[rsc, 2012-01-29 16:54:25]

LGTM

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go
File src/cmd/go/tool.go (right):

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go#newcode42
src/cmd/go/tool.go:42: case 'a' <= c && c <= 'z':
case 'a' <= c && c <= 'z', '0' <= c && c <= '9':
?

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go#newcode93
src/cmd/go/tool.go:93: name = name[:len(name)-4]
s/4/len(".exe")
just to avoid a magic constant

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go#newcode95
src/cmd/go/tool.go:95: fmt.Printf("go tool %s\n", name)
I understand why you're printing 'go tool %s' instead of '%s', but
I think plain %s is probably less surprising here.

Also, accumulate names and sort (or use ioutil.ReadDir).

[r, 2012-01-29 17:11:30]

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go
File src/cmd/go/tool.go (right):

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go#newcode42
src/cmd/go/tool.go:42: case 'a' <= c && c <= 'z':
i think it's easier to read as it is but ok.

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go#newcode93
src/cmd/go/tool.go:93: name = name[:len(name)-4]
On 2012/01/29 16:54:25, rsc wrote:
> s/4/len(".exe")
> just to avoid a magic constant

Done.

http://codereview.appspot.com/5576061/diff/2001/src/cmd/go/tool.go#newcode95
src/cmd/go/tool.go:95: fmt.Printf("go tool %s\n", name)
On 2012/01/29 16:54:25, rsc wrote:
> I understand why you're printing 'go tool %s' instead of '%s', but
> I think plain %s is probably less surprising here.
> 
> Also, accumulate names and sort (or use ioutil.ReadDir).

Done.

[rsc, 2012-01-29 17:17:33]

LGTM

http://codereview.appspot.com/5576061/diff/4003/src/cmd/go/tool.go
File src/cmd/go/tool.go (right):

http://codereview.appspot.com/5576061/diff/4003/src/cmd/go/tool.go#newcode90
src/cmd/go/tool.go:90: sort.StringSlice(names).Sort()
sort.Strings(names)

[r, 2012-01-29 17:19:08]

*** Submitted as 83222b14d7a4 ***

cmd/go: first piece of tool rearrangement
1) create go-tool dir in make.bash
2) clean up stale binaries in make.bash
3) add 'tool' command to go
4) convert goyacc->yacc as a first test tool
Since goyacc stands alone, it's a safe trial.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5576061