code review 5576057: go/doc: enable AllMethods flag (and fix logic)

go/doc: enable AllMethods flag (and fix logic)

- enable AllMethods flag (default: not set)
- fix logic determining which methods to show
- added respective test case in testdata/e.go for AllMethods = false
- added test case set for AllMethods = true

The critical changes/files to look at are:
- testdata/e{0,1,2}.golden: T4.M should only show up as method of T5 in e2.golden
- reader.go: always include top-level methods, and negate former logic for embedded methods
  (rewrote as a switch for better comprehensability)

Fixes issue 2791.

[gri, 2012-01-28 00:11:22]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2012-01-30 19:01:21]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2012-01-31 05:46:44]

LGTM

http://codereview.appspot.com/5576057/diff/5002/src/pkg/go/doc/reader.go
File src/pkg/go/doc/reader.go (right):

http://codereview.appspot.com/5576057/diff/5002/src/pkg/go/doc/reader.go#newc...
src/pkg/go/doc/reader.go:715: case allMethods:
case allMethods, m.Level == 0, !ast.IsExported(removeStar(m.Orig)):

no?

[gri, 2012-01-31 17:48:13]

*** Submitted as 0881a0407213 ***

go/doc: enable AllMethods flag (and fix logic)

- enable AllMethods flag (default: not set)
- fix logic determining which methods to show
- added respective test case in testdata/e.go for AllMethods = false
- added test case set for AllMethods = true

The critical changes/files to look at are:
- testdata/e{0,1,2}.golden: T4.M should only show up as method of T5 in
e2.golden
- reader.go: always include top-level methods, and negate former logic for
embedded methods
  (rewrote as a switch for better comprehensability)

Fixes issue 2791.

R=rsc, rsc
CC=golang-dev
http://codereview.appspot.com/5576057

[gri, 2012-01-31 17:49:15]

On Mon, Jan 30, 2012 at 9:46 PM,  <rsc@google.com> wrote:
> src/pkg/go/doc/reader.go:715: case allMethods:
> case allMethods, m.Level == 0, !ast.IsExported(removeStar(m.Orig)):

Sure. I had the previous form to have a place to put comments, but
it's possible this way, too.
Done.