Issue 5576047: code review 5576047: gobuilder: use go tool

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5576047: code review 5576047: gobuilder: use go tool (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by adg

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gobuilder: use go tool to build and test sub-repositories

Patch Set 2 : diff -r 35c590bd6d5d https://go.googlecode.com/hg #

Patch Set 3 : diff -r 9f95fc15702a https://go.googlecode.com/hg #

Patch Set 4 : diff -r ddf9499f63c6 https://go.googlecode.com/hg #

Patch Set 5 : diff -r ddf9499f63c6 https://go.googlecode.com/hg #

Patch Set 6 : diff -r ddf9499f63c6 https://go.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -24 lines)			Patch
	M	misc/dashboard/builder/http.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	misc/dashboard/builder/main.go	View	1 2 3 4	4 chunks	+48 lines, -22 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 5 months ago (2012-01-25 21:28:16 UTC) #1

rsc

http://codereview.appspot.com/5576047/diff/1/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): http://codereview.appspot.com/5576047/diff/1/misc/dashboard/builder/main.go#newcode390 misc/dashboard/builder/main.go:390: // TODO(adg): do this in a GOPATH that is ...

13 years, 5 months ago (2012-01-25 21:35:42 UTC) #2

adg

PTAL https://codereview.appspot.com/5576047/diff/1/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): https://codereview.appspot.com/5576047/diff/1/misc/dashboard/builder/main.go#newcode390 misc/dashboard/builder/main.go:390: // TODO(adg): do this in a GOPATH that ...

13 years, 5 months ago (2012-01-26 23:30:12 UTC) #3

adg

13 years, 5 months ago (2012-01-30 01:02:20 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=1648a6b65f37 ***

gobuilder: use go tool to build and test sub-repositories

R=rsc
CC=golang-dev
http://codereview.appspot.com/5576047

Expand All Messages | Collapse All Messages