Issue 5574069: code review 5574069: exp/types: generalized GCImporter API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5574069: code review 5574069: exp/types: generalized GCImporter API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by gri

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, lvd1, rsc

Visibility:
Public.

Description

exp/types: generalized GCImporter API. - Renamed ExportData -> FindGcExportData and base it on an a bufio.Reader rather than a filename so it can be used in environments where object files are stored elsewhere. - Factor former GcImporter into GcImportData and GcImport. Implementations with different storage locations for object files can build a customized GcImport using GcImportData. This is pkg/exp only - no impact on Go 1.

Patch Set 1 #

Patch Set 2 : diff -r 7de66de3961c https://code.google.com/p/go #

Patch Set 3 : diff -r a2a95054f3bd https://code.google.com/p/go #

Patch Set 4 : diff -r a77c0f5964b9 https://code.google.com/p/go #

Patch Set 5 : diff -r a77c0f5964b9 https://code.google.com/p/go #

Patch Set 6 : diff -r 81b5bb873a0c https://code.google.com/p/go #

Patch Set 7 : diff -r c8614af8523a https://code.google.com/p/go #

Patch Set 8 : diff -r 87d50a70f7d2 https://code.google.com/p/go #

Patch Set 9 : diff -r 87d50a70f7d2 https://code.google.com/p/go #

Patch Set 10 : diff -r 87d50a70f7d2 https://code.google.com/p/go #

Patch Set 11 : diff -r 556341822a38 https://code.google.com/p/go #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -107 lines)			Patch
M	src/pkg/exp/gotype/gotype.go	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/types/check_test.go	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/types/exportdata.go	View	1 2 3 4 5	7 chunks	+14 lines, -38 lines	0 comments	Download
M	src/pkg/exp/types/gcimporter.go	View	1 2 3 4 5 6 7 8	5 chunks	+99 lines, -58 lines	0 comments	Download
M	src/pkg/exp/types/gcimporter_test.go	View	1 2 3 4 5 6 7	3 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

13 years, 9 months ago (2012-03-20 23:07:45 UTC) #1

gri

13 years, 8 months ago (2012-03-26 18:26:10 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=de7e784537ac ***

exp/types: generalized GCImporter API.

- Renamed ExportData -> FindGcExportData
  and base it on an a bufio.Reader rather
  than a filename so it can be used in
  environments where object files are
  stored elsewhere.

- Factor former GcImporter into GcImportData
  and GcImport. Implementations with different
  storage locations for object files can build
  a customized GcImport using GcImportData.

This is pkg/exp only - no impact on Go 1.

R=golang-dev, lvd, rsc
CC=golang-dev
http://codereview.appspot.com/5574069

Expand All Messages | Collapse All Messages