Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(271)

Issue 5574066: code review 5574066: build: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

build: fix build I said rm, but not hg rm. I never was good at Simon says.

Patch Set 1 #

Patch Set 2 : diff -r 33fdf407a8f1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9564b6730257 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1296 lines) Patch
R src/pkg/net/dict/Makefile View 1 1 chunk +0 lines, -7 lines 0 comments Download
R src/pkg/net/dict/dict.go View 1 1 chunk +0 lines, -210 lines 0 comments Download
R src/pkg/patch/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/patch/apply.go View 1 1 chunk +0 lines, -54 lines 0 comments Download
R src/pkg/patch/git.go View 1 1 chunk +0 lines, -121 lines 0 comments Download
R src/pkg/patch/patch.go View 1 1 chunk +0 lines, -321 lines 0 comments Download
R src/pkg/patch/patch_test.go View 1 1 chunk +0 lines, -390 lines 0 comments Download
R src/pkg/patch/textdiff.go View 1 1 chunk +0 lines, -179 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2012-01-25 20:41:46 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=dcbd37fb3d72 *** build: fix build I said rm, but not hg rm. ...
13 years, 5 months ago (2012-01-25 20:41:51 UTC) #2
bradfitz
13 years, 5 months ago (2012-01-25 22:20:35 UTC) #3
LGTM

On Wed, Jan 25, 2012 at 12:41 PM, <rsc@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: fix build
>
> I said rm, but not hg rm.
> I never was good at Simon says.
>
> Please review this at
http://codereview.appspot.com/**5574066/<http://codereview.appspot.com/5574066/>
>
> Affected files:
>  R src/pkg/net/dict/Makefile
>  R src/pkg/net/dict/dict.go
>  R src/pkg/patch/Makefile
>  R src/pkg/patch/apply.go
>  R src/pkg/patch/git.go
>  R src/pkg/patch/patch.go
>  R src/pkg/patch/patch_test.go
>  R src/pkg/patch/textdiff.go
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b