Issue 5574062: code review 5574062: os/exec: TestExtraFiles - close any leaked file descriptors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5574062: code review 5574062: os/exec: TestExtraFiles - close any leaked file descriptors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by jsing

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

os/exec: TestExtraFiles - close any leaked file descriptors Ensure that file descriptors have not already been leaked into our environment - close any that are open at the start of the TestExtraFiles test. Also use the appropriate command for listing open files.

Patch Set 1 : diff -r af328c5a1d3d https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r af328c5a1d3d https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 3 : diff -r af328c5a1d3d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e3cbb4364149 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	src/pkg/os/exec/exec_test.go	View	1 2	4 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-25 16:06:49 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5574062/diff/5001/src/pkg/os/exec/exec_test.go File src/pkg/os/exec/exec_test.go (right): http://codereview.appspot.com/5574062/diff/5001/src/pkg/os/exec/exec_test.go#newcode216 src/pkg/os/exec/exec_test.go:216: var ofcmd string ofcmd := "lsof" http://codereview.appspot.com/5574062/diff/5001/src/pkg/os/exec/exec_test.go#newcode218 src/pkg/os/exec/exec_test.go:218: ...

13 years, 5 months ago (2012-01-25 16:22:44 UTC) #2

jsing

PTAL http://codereview.appspot.com/5574062/diff/5001/src/pkg/os/exec/exec_test.go File src/pkg/os/exec/exec_test.go (right): http://codereview.appspot.com/5574062/diff/5001/src/pkg/os/exec/exec_test.go#newcode216 src/pkg/os/exec/exec_test.go:216: var ofcmd string On 2012/01/25 16:22:44, bradfitz wrote: ...

13 years, 5 months ago (2012-01-25 16:44:29 UTC) #3

jsing

13 years, 5 months ago (2012-01-31 11:09:13 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b7e029136522 ***

os/exec: TestExtraFiles - close any leaked file descriptors

Ensure that file descriptors have not already been leaked into our
environment - close any that are open at the start of the
TestExtraFiles test.

Also use the appropriate command for listing open files.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5574062

Expand All Messages | Collapse All Messages