Issue 5574053: code review 5574053: encoding/xml: bring API closer to other packages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5574053: code review 5574053: encoding/xml: bring API closer to other packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by niemeyer

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc, gustavo_niemeyer.net

Visibility:
Public.

Description

encoding/xml: bring API closer to other packages Includes gofix module. The only case not covered should be xml.Unmarshal, since it remains with a similar interface, and would require introspecting the type of its first argument better. Fixes issue 2626.

Patch Set 1 #

Patch Set 2 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r bf7fe7752318 https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+494 lines, -349 lines)			Patch
M	misc/dashboard/builder/main.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/godoc/codewalk.go	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gofix/Makefile	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/cmd/gofix/xmlapi.go	View	1 2 3 4 5 6	1 chunk	+96 lines, -0 lines	0 comments	Download
A	src/cmd/gofix/xmlapi_test.go	View	1 2 4 6	1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/pkg/encoding/xml/marshal.go	View	1 2 3 4 5	3 chunks	+31 lines, -10 lines	0 comments	Download
M	src/pkg/encoding/xml/marshal_test.go	View	1 2	5 chunks	+6 lines, -13 lines	0 comments	Download
M	src/pkg/encoding/xml/read.go	View	1 2 3 4 5 6 7	7 chunks	+27 lines, -34 lines	0 comments	Download
M	src/pkg/encoding/xml/read_test.go	View	1 2	5 chunks	+4 lines, -5 lines	0 comments	Download
M	src/pkg/encoding/xml/xml.go	View	1 2	26 chunks	+241 lines, -241 lines	0 comments	Download
M	src/pkg/encoding/xml/xml_test.go	View	1 2	14 chunks	+39 lines, -42 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-01-24 02:52:43 UTC) #1

gustavo_niemeyer.net

On Tue, Jan 24, 2012 at 00:55, Russ Cox <rsc@golang.org> wrote: > LGTM > > ...

13 years, 2 months ago (2012-01-24 03:07:59 UTC) #3

niemeyer

13 years, 2 months ago (2012-01-24 03:10:41 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f10dfb8fa0eb ***

encoding/xml: bring API closer to other packages

Includes gofix module. The only case not covered should be
xml.Unmarshal, since it remains with a similar interface, and
would require introspecting the type of its first argument
better.

Fixes issue 2626.

R=golang-dev, rsc, gustavo
CC=golang-dev
http://codereview.appspot.com/5574053

Expand All Messages | Collapse All Messages