Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 5574050: Default --title on --message and clamp at 100 chars (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by M-A
Modified:
14 years, 4 months ago
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

Default --title on --message and clamp at 100 chars

Patch Set 1 #

Patch Set 2 : inconditionally strip #

Total comments: 4

Patch Set 3 : Testing a very very very very very very very very very very very very very very very very very very… #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M upload.py View 1 2 3 chunks +22 lines, -10 lines 1 comment Download

Messages

Total messages: 5
M-A
It's more or less what chromium's wrapper tools are doing. I thought about using "…" ...
14 years, 4 months ago (2012-01-23 19:39:12 UTC) #1
Andi Albrecht
LGTM On 2012/01/23 19:39:12, M-A wrote: > It's more or less what chromium's wrapper tools ...
14 years, 4 months ago (2012-01-23 19:51:49 UTC) #2
Andi Albrecht
sorry, I've had two comments - but just nits, so it's still a LGTM http://codereview.appspot.com/5574050/diff/2001/upload.py ...
14 years, 4 months ago (2012-01-23 19:52:42 UTC) #3
M-A
Now with ÜTF-8 requirement. http://codereview.appspot.com/5574050/diff/2001/upload.py File upload.py (right): http://codereview.appspot.com/5574050/diff/2001/upload.py#newcode2249 upload.py:2249: title or message.split('\n', 1)[0].strip() or ...
14 years, 4 months ago (2012-01-23 20:04:43 UTC) #4
Andi Albrecht
14 years, 4 months ago (2012-01-23 20:12:12 UTC) #5
http://codereview.appspot.com/5574050/diff/2001/upload.py
File upload.py (right):

http://codereview.appspot.com/5574050/diff/2001/upload.py#newcode2249
upload.py:2249: title or message.split('\n', 1)[0].strip() or
raw_input(prompt)).strip()
I'm not sure about the correct indentation level here. 2 spaces seems to fit
fine with the rest of the file.

On 2012/01/23 20:04:43, M-A wrote:
> On 2012/01/23 19:52:43, Andi Albrecht wrote:
> > Indent 2 spaces
> 
> Why? It's like a function call, no?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b