code review 5573060: net: fix dialing google test

net: fix dialing google test

[mikio, 2012-01-25 01:46:59]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-01-25 01:52:02]

Seems like http://www.google.com/robots.txt might be more stable long-term.

On Tue, Jan 24, 2012 at 5:46 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: fix dialing google test
>
> Please review this at
http://codereview.appspot.com/**5573060/<http://codereview.appspot.com/5573060/>
>
> Affected files:
>  M src/pkg/net/dialgoogle_test.go
>
>
> Index: src/pkg/net/dialgoogle_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/dialgoogle_test.**go
> +++ b/src/pkg/net/dialgoogle_test.**go
> @@ -19,7 +19,7 @@
>  // fd is already connected to the destination, port 80.
>  // Run an HTTP request to fetch the appropriate page.
>  func fetchGoogle(t *testing.T, fd Conn, network, addr string) {
> -       req := []byte("GET /intl/en/privacy/ HTTP/1.0\r\nHost:
> www.google.com\r\n\r\n")
> +       req := []byte("GET /intl/en/policies/ HTTP/1.0\r\nHost:
> www.google.com\r\n\r\n")
>        n, err := fd.Write(req)
>
>        buf := make([]byte, 1000)
>
>
>

[mikio, 2012-01-25 02:00:33]

On Wed, Jan 25, 2012 at 10:52 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Seems like http://www.google.com/robots.txt might be more stable long-term.

Or somewhere in golang.org?

[mikio, 2012-01-25 02:02:39]

On Wed, Jan 25, 2012 at 11:00 AM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> Or somewhere in golang.org?

Nope, golang.org does not support IPv6 yet.

[bradfitz, 2012-01-25 02:02:40]

I trust www.google.com more. Has a couple more servers too.
On Jan 24, 2012 6:00 PM, "Mikio Hara" <mikioh.mikioh@gmail.com> wrote:

> On Wed, Jan 25, 2012 at 10:52 AM, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
> > Seems like http://www.google.com/robots.txt might be more stable
> long-term.
>
> Or somewhere in golang.org?
>

[mikio, 2012-01-25 02:03:15]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-25 22:06:49]

LGTM

[mikio, 2012-01-25 22:38:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=2994bd083608 ***

net: fix dialing google test

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5573060