Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(781)

Issue 5573046: code review 5573046: go/doc: test all operation modes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by gri
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/doc: test all operation modes Golden files have extension .d.golden where d is the mode value (0 or 1 for now) (i.e., testdata/file.out is now testdata/file.0.golden, and there is a new file testdata/file.1.golden for each testcase)

Patch Set 1 #

Patch Set 2 : diff -r bc07ad621734 https://code.google.com/p/go #

Patch Set 3 : diff -r bc07ad621734 https://code.google.com/p/go #

Patch Set 4 : diff -r bc07ad621734 https://code.google.com/p/go #

Patch Set 5 : diff -r bc07ad621734 https://code.google.com/p/go #

Patch Set 6 : diff -r 9e3f8cd86a85 https://code.google.com/p/go #

Patch Set 7 : diff -r 802d4c3a4254 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -256 lines) Patch
M src/pkg/go/doc/doc_test.go View 1 2 3 5 chunks +9 lines, -3 lines 0 comments Download
A src/pkg/go/doc/testdata/a.0.golden View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/a.1.golden View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M src/pkg/go/doc/testdata/a0.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/doc/testdata/a1.go View 1 1 chunk +1 line, -1 line 0 comments Download
R src/pkg/go/doc/testdata/alpha.out View 1 4 5 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/go/doc/testdata/b.out View 1 4 5 1 chunk +0 lines, -34 lines 0 comments Download
A src/pkg/go/doc/testdata/b.0.golden View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/b.1.golden View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
R src/pkg/go/doc/testdata/c.out View 1 4 5 1 chunk +0 lines, -48 lines 0 comments Download
A src/pkg/go/doc/testdata/c.0.golden View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/c.1.golden View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
R src/pkg/go/doc/testdata/testing.out View 1 4 5 1 chunk +0 lines, -156 lines 0 comments Download
A src/pkg/go/doc/testdata/testing.0.golden View 1 2 3 1 chunk +156 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/testing.1.golden View 1 2 3 1 chunk +298 lines, -0 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
13 years, 5 months ago (2012-01-23 18:21:38 UTC) #1
rsc
How about s/.0/.0.txt/ and so on? When you get up to 6 and 8 they're ...
13 years, 5 months ago (2012-01-23 18:23:59 UTC) #2
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 5 months ago (2012-01-23 18:32:16 UTC) #3
rsc
LGTM
13 years, 5 months ago (2012-01-23 18:33:34 UTC) #4
gri
13 years, 5 months ago (2012-01-23 18:41:56 UTC) #5
*** Submitted as 29b7347f0db1 ***

go/doc: test all operation modes

Golden files have extension .d.golden where d is the mode value (0 or 1 for now)
(i.e., testdata/file.out is now testdata/file.0.golden, and there is a new file
testdata/file.1.golden for each testcase)

R=rsc
CC=golang-dev
http://codereview.appspot.com/5573046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b