Issue 5572083: code review 5572083: cmd/goinstall: remove now that 'go get' works

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5572083: code review 5572083: cmd/goinstall: remove now that 'go get' works (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by niemeyer

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/goinstall: remove now that 'go get' works The changes to builder were not tested.

Patch Set 1 #

Patch Set 2 : code review 5572083: cmd/goinstall: remove now that 'go get' works #

Patch Set 3 : diff -r f36b37b08176 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f36b37b08176 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f36b37b08176 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r f36b37b08176 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r fcbc3e9d755a https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1563 lines)			Patch
M	src/cmd/Makefile	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
R	src/cmd/goinstall/Makefile	View	1 2	1 chunk	+0 lines, -19 lines	0 comments	Download
R	src/cmd/goinstall/doc.go	View	1 2	1 chunk	+0 lines, -200 lines	0 comments	Download
R	src/cmd/goinstall/download.go	View	1 2	1 chunk	+0 lines, -537 lines	0 comments	Download
R	src/cmd/goinstall/download_test.go	View	1 2	1 chunk	+0 lines, -149 lines	0 comments	Download
R	src/cmd/goinstall/main.go	View	1 2	1 chunk	+0 lines, -400 lines	0 comments	Download
R	src/cmd/goinstall/make.go	View	1 2	1 chunk	+0 lines, -183 lines	0 comments	Download
R	src/cmd/goinstall/tag_test.go	View	1 2	1 chunk	+0 lines, -73 lines	0 comments	Download
M	src/pkg/Makefile	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-29 17:52:39 UTC) #1

rsc

Please revert the builder changes; then LGTM. Andrew is working on the builder already; I ...

13 years, 5 months ago (2012-01-29 18:08:45 UTC) #2

niemeyer

*** Submitted as http://code.google.com/p/go/source/detail?r=7b819318c606 *** cmd/goinstall: remove now that 'go get' works The changes to ...

13 years, 5 months ago (2012-01-29 19:22:28 UTC) #3

niemeyer

13 years, 5 months ago (2012-01-29 19:23:25 UTC) #4

On 2012/01/29 19:22:28, niemeyer wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=7b819318c606 ***
> 
> cmd/goinstall: remove now that 'go get' works
> 
> The changes to builder were not tested.

Sorry, forgot to update the CL description. There are no changes to the builder.

Expand All Messages | Collapse All Messages