Issue 5572081: code review 5572081: gc: use original constant expression in error messages.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5572081: code review 5572081: gc: use original constant expression in error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by remyoudompheng

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, lvd, iant2, remy_archlinux.org

Visibility:
Public.

Description

gc: use original constant expression in error messages. Fixes issue 2768.

Patch Set 2 : diff -r 8179934cf77e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8179934cf77e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 8179934cf77e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 23995c78329e https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	src/cmd/gc/export.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/fixedbugs/bug381.go	View	1 2 3	1 chunk	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-28 17:33:32 UTC) #1

iant2

FYI http://codereview.appspot.com/5572081/diff/3001/test/fixedbugs/bug381.go File test/fixedbugs/bug381.go (right): http://codereview.appspot.com/5572081/diff/3001/test/fixedbugs/bug381.go#newcode15 test/fixedbugs/bug381.go:15: // bug378.go:30: cannot use 3 (type time.Weekday) as ...

13 years, 5 months ago (2012-01-29 04:35:50 UTC) #3

remyoudompheng

Hello golang-dev@googlegroups.com, lvd@google.com, iant@google.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.

13 years, 5 months ago (2012-01-29 09:28:17 UTC) #4

remyoudompheng

13 years, 5 months ago (2012-01-29 09:36:09 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=3c968bfb3b3f ***

gc: use original constant expression in error messages.

Fixes issue 2768.

R=golang-dev, lvd, iant
CC=golang-dev, remy
http://codereview.appspot.com/5572081

Expand All Messages | Collapse All Messages