Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(302)

Issue 5571059: code review 5571059: html: move the HTML parser to an exp/html package. The ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by nigeltao
Modified:
13 years, 9 months ago
Reviewers:
CC:
rsc, dsymonds, golang-dev
Visibility:
Public.

Description

html: move the HTML parser to an exp/html package. The parser is a work in progress, and we are not ready to freeze its API for Go 1. Package html still exists, containing just two functions: EscapeString and UnescapeString. Both the packages at exp/html and html are "package html". The former is a superset of the latter. At some point in the future, the exp/html code will move back into html, once we have finalized the parser API.

Patch Set 1 #

Patch Set 2 : diff -r 1d59cc4f3044 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1d59cc4f3044 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 20a3a96e61b2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-52 lines, --49 lines) Patch
M src/pkg/Makefile View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/exp/html/Makefile View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/html/const.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/doc.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/doctype.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/entity.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/entity_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/escape.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/foreign.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/node.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/parse.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/parse_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/render.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/render_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/README View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/adoption01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/adoption02.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/comments01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/doctype01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/entities01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/entities02.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/html5test-com.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/inbody01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/isindex.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/pending-spec-changes.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/pending-spec-changes-plain-text-unsafe.dat View 1 Binary file 0 comments Download
M src/pkg/exp/html/testdata/webkit/plain-text-unsafe.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/scriptdata01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/scripted/adoption01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/scripted/webkit01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tables01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests1.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests10.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests11.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests12.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests14.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests15.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests16.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests17.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests18.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests19.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests2.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests20.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests21.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests22.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests23.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests24.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests25.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests26.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests3.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests4.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests5.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests6.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests7.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests8.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests9.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests_innerHTML_1.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tricky01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/webkit01.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/webkit02.dat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/token.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/html/token_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/Makefile View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/pkg/html/escape.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
nigeltao
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 9 months ago (2012-01-24 23:42:34 UTC) #1
dsymonds
This means that html/template has to move too.
13 years, 9 months ago (2012-01-24 23:45:20 UTC) #2
dsymonds
On Wed, Jan 25, 2012 at 10:45 AM, David Symonds <dsymonds@golang.org> wrote: > This means ...
13 years, 9 months ago (2012-01-24 23:47:08 UTC) #3
rsc
Yes, we've arranged that html/template need not move, which is good because it's a very ...
13 years, 9 months ago (2012-01-24 23:48:31 UTC) #4
rsc
LGTM
13 years, 9 months ago (2012-01-24 23:48:54 UTC) #5
nigeltao
13 years, 9 months ago (2012-01-24 23:55:15 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=99ce1d30e1d2 ***

html: move the HTML parser to an exp/html package. The parser is a
work in progress, and we are not ready to freeze its API for Go 1.

Package html still exists, containing just two functions: EscapeString
and UnescapeString.

Both the packages at exp/html and html are "package html". The former
is a superset of the latter.

At some point in the future, the exp/html code will move back into
html, once we have finalized the parser API.

R=rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/5571059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b