Issue 5571058: code review 5571058: encoding/binary: document that PutVarint, PutUvarint ma...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5571058: code review 5571058: encoding/binary: document that PutVarint, PutUvarint ma... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by bradfitz

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

encoding/binary: document that PutVarint, PutUvarint may panic Fixes issue 2628

Patch Set 2 : diff -r d033a372fd90 https://go.googlecode.com/hg #

Patch Set 3 : diff -r d033a372fd90 https://go.googlecode.com/hg #

Total comments: 2

Patch Set 4 : diff -r d033a372fd90 https://go.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/encoding/binary/varint.go	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 5 months ago (2012-01-24 22:13:24 UTC) #1

gri

LGTM http://codereview.appspot.com/5571058/diff/1002/src/pkg/encoding/binary/varint.go File src/pkg/encoding/binary/varint.go (right): http://codereview.appspot.com/5571058/diff/1002/src/pkg/encoding/binary/varint.go#newcode40 src/pkg/encoding/binary/varint.go:40: // If the buffer is too small, the ...

13 years, 5 months ago (2012-01-24 22:15:20 UTC) #2

bradfitz

13 years, 5 months ago (2012-01-24 22:20:02 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c59c06b5d783 ***

encoding/binary: document that PutVarint, PutUvarint may panic

Fixes issue 2628

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5571058

Expand All Messages | Collapse All Messages