Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 5571052: code review 5571052: net/http: parse CONNECT requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by andybalholm
Modified:
12 years, 2 months ago
Reviewers:
CC:
dsymonds, rsc, golang-dev
Visibility:
Public.

Description

net/http: parse CONNECT requests Fixes issue 2755

Patch Set 1 #

Patch Set 2 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r f6002b0fbe36 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M src/pkg/net/http/readrequest_test.go View 1 1 chunk +69 lines, -0 lines 0 comments Download
M src/pkg/net/http/request.go View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6
andybalholm
Hello golang-dev@googlegroups.com (cc: dsymonds@golang.org, golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2012-01-24 01:15:01 UTC) #1
dsymonds
LGTM but wait for rsc to weigh in. http://codereview.appspot.com/5571052/diff/4001/src/pkg/net/http/request.go File src/pkg/net/http/request.go (right): http://codereview.appspot.com/5571052/diff/4001/src/pkg/net/http/request.go#newcode470 src/pkg/net/http/request.go:470: // ...
12 years, 2 months ago (2012-01-24 01:50:09 UTC) #2
andybalholm
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com, rsc@golang.org), Please take another look.
12 years, 2 months ago (2012-01-24 04:58:06 UTC) #3
rsc
LGTM Thanks.
12 years, 2 months ago (2012-01-24 16:04:43 UTC) #4
andybalholm
Are we still waiting for something, or is this ready for one of you to ...
12 years, 2 months ago (2012-01-25 00:27:56 UTC) #5
dsymonds
12 years, 2 months ago (2012-01-25 00:42:22 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=fa55f3ffda22 ***

net/http: parse CONNECT requests

Fixes issue 2755

R=dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5571052

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b