Issue 5570043: code review 5570043: Add the NOTE_* syscall constants on Darwin, for use wit...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5570043: code review 5570043: Add the NOTE_* syscall constants on Darwin, for use wit... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by robfig

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Add the NOTE_* syscall constants on Darwin, for use with kqueue: http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man2/kqueue.2.html ./all.bash passes, and I re-generated zerrors for darwin using the command that they gave at the top.

Patch Set 1 #

Patch Set 2 : diff -r b372a927701e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b372a927701e https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2111 lines, -2039 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_386.go	View	1	1 chunk	+1055 lines, -1019 lines	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_amd64.go	View	1	1 chunk	+1055 lines, -1019 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

robfig

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-23 02:15:15 UTC) #1

rsc

Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright Thanks. Russ

13 years, 5 months ago (2012-01-24 19:08:24 UTC) #3

robfig

On 2012/01/24 19:08:24, rsc wrote: > Please complete a CLA as described at > http://golang.org/doc/contribute.html#copyright ...

13 years, 5 months ago (2012-01-25 01:27:43 UTC) #4

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=602b75a41065 *** syscall: add NOTE_* constants on OS X R=rsc CC=golang-dev http://codereview.appspot.com/5570043 ...

13 years, 5 months ago (2012-01-25 20:50:27 UTC) #5

*** Abandoned ***

Expand All Messages | Collapse All Messages