code review 5569091: dashboard: ask builders to re-build Go tip to freshen s...

dashboard: ask builders to re-build Go tip to freshen subrepos

This ensures we always have results for subrepo-tip at go-tip.

[adg, 2012-01-30 03:34:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[dsymonds, 2012-01-30 03:45:10]

LGTM

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/build.go
File misc/dashboard/app/build/build.go (right):

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/build.g...
misc/dashboard/app/build/build.go:268: err := datastore.Get(c, com.Key(c), &com)
you're passing a **Commit here.

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/handler.go
File misc/dashboard/app/build/handler.go (right):

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/handler...
misc/dashboard/app/build/handler.go:229: c.Warningf("no Commit found: %v", pkg)
log the error too.

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/ui.go
File misc/dashboard/app/build/ui.go (right):

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/ui.go#n...
misc/dashboard/app/build/ui.go:148: c.Warningf("no Commit found: %v", pkg)
log error

[adg, 2012-01-30 03:49:00]

PTAL

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/build.go
File misc/dashboard/app/build/build.go (right):

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/build.g...
misc/dashboard/app/build/build.go:268: err := datastore.Get(c, com.Key(c), &com)
On 2012/01/30 03:45:10, dsymonds wrote:
> you're passing a **Commit here.

Fixed. (Interestingly, it works anyway.)

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/handler.go
File misc/dashboard/app/build/handler.go (right):

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/handler...
misc/dashboard/app/build/handler.go:229: c.Warningf("no Commit found: %v", pkg)
On 2012/01/30 03:45:10, dsymonds wrote:
> log the error too.

Done.

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/ui.go
File misc/dashboard/app/build/ui.go (right):

http://codereview.appspot.com/5569091/diff/1/misc/dashboard/app/build/ui.go#n...
misc/dashboard/app/build/ui.go:148: c.Warningf("no Commit found: %v", pkg)
On 2012/01/30 03:45:10, dsymonds wrote:
> log error

Done.

[dsymonds, 2012-01-30 03:50:27]

LGTM

[adg, 2012-01-30 03:50:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=b35c38ef55fa ***

dashboard: ask builders to re-build Go tip to freshen subrepos

This ensures we always have results for subrepo-tip at go-tip.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5569091