Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6578)

Issue 5569045: Run regression tests for lilypond-book (issue 2223). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Julien Rioux
Modified:
4 years, 2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Run regression tests for lilypond-book (issue 2223). Re-enable running the regtests in input/regression/lilypond-book. Fix various typos, clarify what each input file tests for and how the output should look, and fix the following problems: collated-files.tely: Was linking to the input files rather than the output files generated by lilypond-book. The input files were thus not tested individually as it should but as included files. Fixed in the local GNUmakefile by an explicit rule for collated-files.list which tracks the output files. suffix-texi: Failed, was not being preprocessed by lilypond-book but simply copied to the output folder. Fixed in the local GNUmakefile by adding a specific make rule for it. tex-twocolumn: Failed, image had full-page width. Fixed in the input file by moving \twocolumn to the preamble. Column width detection in the body of the tex document is not yet implemented. texinfo-language-detection: Suspicious, had a weird @lydoctitle popping up. Fixed in the input file by defining the @lydoctitle macro.

Patch Set 1 #

Patch Set 2 : Prevent lilypond-book from running in parallel. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -46 lines) Patch
M input/regression/lilypond-book/GNUmakefile View 1 1 chunk +21 lines, -2 lines 3 comments Download
M input/regression/lilypond-book/html-newline-after-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/html-space-after-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/html-version.html View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/html-version-newline.html View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/include3.ily View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/lilypond-book/tex-comment-firstline.lytex View 1 chunk +2 lines, -1 line 0 comments Download
M input/regression/lilypond-book/tex-graphics-package-added.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-include-file.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-include-options.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-inline-lilypond.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-lilypond-inside-itemize.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-lilypond-inside-table.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-musicxml-file.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-musicxml-file-options.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-paragraphs.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-snippet-options.lytex View 1 chunk +18 lines, -9 lines 0 comments Download
M input/regression/lilypond-book/tex-twocolumn.lytex View 1 chunk +27 lines, -4 lines 0 comments Download
M input/regression/lilypond-book/tex-verbatim.lytex View 2 chunks +4 lines, -3 lines 0 comments Download
M input/regression/lilypond-book/tex-version.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/texinfo-include-language-detection.tely View 1 chunk +5 lines, -0 lines 0 comments Download
M input/regression/lilypond-book/texinfo-language-detection.tely View 1 chunk +5 lines, -0 lines 0 comments Download
M input/regression/lilypond-book/texinfo-musicxml-file.tely View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/lilypond-book/texinfo-musicxml-file-options.tely View 1 chunk +2 lines, -2 lines 0 comments Download
A + input/regression/lilypond-book/texinfo-papersize-docs.tely View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/lys-to-tely.py View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6
Julien Rioux
Please review.
12 years, 3 months ago (2012-01-23 20:01:50 UTC) #1
Graham Percival
LGTM
12 years, 3 months ago (2012-01-25 22:12:36 UTC) #2
Graham Percival
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode19 input/regression/lilypond-book/GNUmakefile:19: OUT_TEXI_FILES += ${TEXI_FILES:%.texi=$(outdir)/%.info} how are the OUT_X_Y definitions used? ...
12 years, 2 months ago (2012-02-07 20:05:49 UTC) #3
Julien Rioux
On 2012/02/07 20:05:49, Graham Percival wrote: > http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile > File input/regression/lilypond-book/GNUmakefile (right): > > http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode19 ...
12 years, 2 months ago (2012-02-07 20:20:35 UTC) #4
hanwenn
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile:36: # Prevent parallel lilypond-book instances for this subdir I ...
4 years, 2 months ago (2020-02-22 22:54:40 UTC) #5
Julien Rioux
4 years, 2 months ago (2020-02-25 05:16:48 UTC) #6
Message was sent while issue was closed.
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-bo...
File input/regression/lilypond-book/GNUmakefile (right):

https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-bo...
input/regression/lilypond-book/GNUmakefile:36: # Prevent parallel lilypond-book
instances for this subdir
On 2020/02/22 22:54:40, hanwenn wrote:
> I know this is a long time ago, but can you remember why this was added?

As far as I can remember, lilypond-book was not free of concurrency issues with
its use of a cache for snippets. Therefore the simplest to avoid any issue with
make -j was to disable concurrent calls to lilypond-book.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b