Issue 5564056: code review 5564056: go/printer, gofmt: respect line breaks in signatures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5564056: code review 5564056: go/printer, gofmt: respect line breaks in signatures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gri

Modified:
13 years, 5 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: respect line breaks in signatures No changes when applying gofmt to src, misc. Fixes issue 2597.

Patch Set 1 #

Patch Set 2 : diff -r af328c5a1d3d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r af328c5a1d3d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r af328c5a1d3d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8c18982b529f https://code.google.com/p/go #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -30 lines)			Patch
M	src/pkg/go/printer/nodes.go	View	1 2	2 chunks	+30 lines, -14 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.golden	View	1	2 chunks	+34 lines, -16 lines	0 comments	Download
M	src/pkg/go/printer/testdata/linebreaks.golden	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/linebreaks.input	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-25 06:39:57 UTC) #1

gri

13 years, 5 months ago (2012-01-25 18:21:15 UTC) #3

*** Submitted as ff042302f8f2 ***

go/printer, gofmt: respect line breaks in signatures

No changes when applying gofmt to src, misc.

Fixes issue 2597.

R=r
CC=golang-dev
http://codereview.appspot.com/5564056

Expand All Messages | Collapse All Messages