code review 5564048: doc: add explicit types for godoc & API checker tool

crypto: rename some FooError to ErrFoo

Also, add an explicit error type when the right hand side is an unexported
function.

[bradfitz, 2012-01-24 02:07:21]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-01-24 03:07:49]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-01-24 03:08:31]

I had forgot to include read_test.go in this CL.

Also, +agl.

On Mon, Jan 23, 2012 at 7:07 PM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5564048/<http://codereview.appspot.com/5564048/>
>

[gri, 2012-01-24 03:33:12]

I suggets to revert all unnecessary type annotations.

Most of these could be handled w/ a little bit of "cheap type checking" in the
existing tools, for instance gofix does some of this.

I agree w/ Rob that we shouldn't pollute our sources this way.

The ErrX rename is fine.

[rog, 2012-01-24 11:43:39]

On 2012/01/24 03:33:12, gri wrote:
> I suggets to revert all unnecessary type annotations.
> 
> Most of these could be handled w/ a little bit of "cheap type checking" in the
> existing tools, for instance gofix does some of this.
> 
> I agree w/ Rob that we shouldn't pollute our sources this way.
> 
> The ErrX rename is fine.

i like the explicit types on the error values too - it means one can do, say:
err := errors.ErrKeyIncorrect and err would be of type error, not of an
inconvenient unexported type.

[agl1, 2012-01-24 12:10:21]

openpgp changes: LGTM

[rsc, 2012-01-24 15:55:04]

Please revert the non-crypto changes.  Then LGTM.
We can worry about the other packages separately.

[bradfitz, 2012-01-24 16:32:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=d54721805232 ***

crypto: rename some FooError to ErrFoo

Also, add an explicit error type when the right hand side is an unexported
function.

R=golang-dev, gri, rogpeppe, agl, rsc
CC=golang-dev
http://codereview.appspot.com/5564048