Issue 5563047: convert-ly: Handle malformed \version string (issue 2044).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5563047: convert-ly: Handle malformed \version string (issue 2044). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Julien Rioux

Modified:
12 years, 3 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

convert-ly: Handle malformed \version string (issue 2044).

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	scripts/convert-ly.py	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Julien Rioux

Simple patch to issue a warning when the \version string is malformed.

12 years, 3 months ago (2012-01-21 23:28:07 UTC) #1

Julien Rioux

12 years, 3 months ago (2012-01-21 23:49:54 UTC) #3

On Sat, Jan 21, 2012 at 6:36 PM,  <graham@percival-music.ca> wrote:
> LGTM, please push directly to staging
>
> http://codereview.appspot.com/5563047/


I noticed that there is already an InvalidVersion exception, so I am
going to use that and push the result.

Thanks,
Julien

Expand All Messages | Collapse All Messages