Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 5562051: code review 5562051: FAQ: update to Go 1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by r
Modified:
13 years, 4 months ago
Reviewers:
CC:
adg, rsc, r2, golang-dev
Visibility:
Public.

Description

FAQ: update to Go 1.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 37ae66e4fa5e https://code.google.com/p/go/ #

Total comments: 3

Patch Set 3 : diff -r 44abf78c0f28 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 44abf78c0f28 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -63 lines) Patch
M doc/go_faq.html View 1 2 3 25 chunks +75 lines, -63 lines 0 comments Download

Messages

Total messages: 8
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 4 months ago (2012-01-22 23:12:04 UTC) #1
adg
LGTM http://codereview.appspot.com/5562051/diff/1/doc/go_faq.html File doc/go_faq.html (right): http://codereview.appspot.com/5562051/diff/1/doc/go_faq.html#newcode768 doc/go_faq.html:768: In Go 1, equality has been defined for ...
13 years, 4 months ago (2012-01-22 23:16:57 UTC) #2
rsc
LGTM All of our other docs use tabs. Should probably keep the tabs here too. ...
13 years, 4 months ago (2012-01-23 14:50:13 UTC) #3
r2
On Jan 23, 2012, at 6:50 AM, rsc@golang.org wrote: > LGTM > > All of ...
13 years, 4 months ago (2012-01-23 16:27:24 UTC) #4
r
http://codereview.appspot.com/5562051/diff/4001/doc/go_faq.html File doc/go_faq.html (right): http://codereview.appspot.com/5562051/diff/4001/doc/go_faq.html#newcode1351 doc/go_faq.html:1351: For instance, <a href="/test/bench/shootout">test/bench/shootout</a>/pidigits depends on a multi-precision math ...
13 years, 4 months ago (2012-01-23 16:29:27 UTC) #5
rsc
We should figure out what the story is with tabs or not. If you grep ...
13 years, 4 months ago (2012-01-23 16:34:25 UTC) #6
r2
On Jan 23, 2012, at 8:34 AM, Russ Cox wrote: > We should figure out ...
13 years, 4 months ago (2012-01-23 16:37:15 UTC) #7
r
13 years, 4 months ago (2012-01-23 16:39:57 UTC) #8
*** Submitted as 21c56311deab ***

FAQ: update to Go 1.

R=adg, rsc, r
CC=golang-dev
http://codereview.appspot.com/5562051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b