code review 5562049: gob: reduce the maximum message size

gob: reduce the maximum message size
It was 2^31, but that could cause overflow and trouble.
Reduce it to 2^30 and add a TODO.

[r, 2012-01-22 19:12:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant2, 2012-01-22 19:46:02]

LGTM

r@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> gob: reduce the maximum message size
> It was 2^31, but that could cause overflow and trouble.
> Reduce it to 2^30 and add a TODO.
>
> Please review this at http://codereview.appspot.com/5562049/
>
> Affected files:
>   M src/pkg/encoding/gob/decoder.go
>
>
> Index: src/pkg/encoding/gob/decoder.go
> ===================================================================
> --- a/src/pkg/encoding/gob/decoder.go
> +++ b/src/pkg/encoding/gob/decoder.go
> @@ -75,7 +75,9 @@
>  		dec.err = err
>  		return false
>  	}
> -	if nbytes >= 1<<31 {
> +	// Upper limit of 1GB, allowing room to grow a little without overflow.
> +	// TODO: We might want more control over this limit.
> +	if nbytes >= 1<<30 {
>  		dec.err = errBadCount
>  		return false
>  	}

[r, 2012-01-22 20:01:15]

*** Submitted as ed752e72f3d7 ***

gob: reduce the maximum message size
It was 2^31, but that could cause overflow and trouble.
Reduce it to 2^30 and add a TODO.

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5562049