Issue 5562047: code review 5562047: net: consistent OpError message

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5562047: code review 5562047: net: consistent OpError message (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by mikio

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: consistent OpError message

Patch Set 1 #

Patch Set 2 : diff -r bad5895b4270 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bad5895b4270 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e88af847410b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r bc07ad621734 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -29 lines)			Patch
M	src/pkg/net/iprawsock_posix.go	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/tcpsock_plan9.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/tcpsock_posix.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/udpsock_plan9.go	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/udpsock_posix.go	View	1 2 3	7 chunks	+16 lines, -16 lines	0 comments	Download
M	src/pkg/net/unixsock_posix.go	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-01-22 11:16:55 UTC) #1

rsc

I prefer the old messages. There's no need to say tcp twice in the dialtcp ...

13 years, 5 months ago (2012-01-23 14:30:19 UTC) #2

mikio

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2012-01-23 14:52:29 UTC) #3

mikio

13 years, 5 months ago (2012-01-23 17:59:50 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=9e3f8cd86a85 ***

net: consistent OpError message

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5562047

Expand All Messages | Collapse All Messages