Issue 5561047: code review 5561047: go/doc: avoid the name 'a.out' in the testdata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5561047: code review 5561047: go/doc: avoid the name 'a.out' in the testdata (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, gri, r

Visibility:
Public.

Description

go/doc: avoid the name 'a.out' in the testdata

Patch Set 2 : diff -r 48150b06645c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 48150b06645c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r f46afd406b5c https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	src/pkg/go/doc/testdata/a0.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/doc/testdata/a1.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/doc/testdata/alpha.out	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2012-01-20 17:55:05 UTC) #1

http://codereview.appspot.com/5561047/diff/2002/src/pkg/go/doc/testdata/alpha.out File src/pkg/go/doc/testdata/alpha.out (right): http://codereview.appspot.com/5561047/diff/2002/src/pkg/go/doc/testdata/alpha.out#newcode2 src/pkg/go/doc/testdata/alpha.out:2: PACKAGE a alpha?

13 years, 9 months ago (2012-01-20 17:57:20 UTC) #3

rsc

13 years, 9 months ago (2012-01-20 18:34:14 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=3d6fc7c94cd1 ***

go/doc: avoid the name 'a.out' in the testdata

R=golang-dev, gri, r
CC=golang-dev
http://codereview.appspot.com/5561047

Expand All Messages | Collapse All Messages