code review 5557068: cgo: -cdefs should translate unsafe.Pointer to void *

cgo: -cdefs should translate unsafe.Pointer to void *
        Fixes issue 2454.

[minux1, 2012-01-20 11:52:56]

Hello rsc@golang.org, mikioh.mikioh@gmail.com, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2012-01-20 14:52:00]

Can one of the existing cgo tests be extended to test this case as well?

[minux1, 2012-01-20 15:26:04]

On Fri, Jan 20, 2012 at 10:52 PM, <iant@golang.org> wrote:

> Can one of the existing cgo tests be extended to test this case as well?
>
AFAIK, currently there is no test for 'cgo -cdefs'.
(The reason I think is that 'cgo -cdefs' is only for bootstrap of package
runtime,
e.g., internal use only. IMHO, It probably should not even be mentioned in
'cgo -help',
although the current help text for -cdefs is already:

>   -cdefs=false: for bootstrap: write C definitions for C file to standard
> output
>
).

[minux1, 2012-01-20 15:53:05]

On Fri, Jan 20, 2012 at 10:52 PM, <iant@golang.org> wrote:

> Can one of the existing cgo tests be extended to test this case as well?
>
Of course, if necessary, I could write a new test just for 'cgo -cdefs'.
But, how about 'cgo -godefs' (it doesn't have any tests too, AFAIK)?

[iant2, 2012-01-20 16:20:51]

minux <minux.ma@gmail.com> writes:

> On Fri, Jan 20, 2012 at 10:52 PM, <iant@golang.org> wrote:
>
>> Can one of the existing cgo tests be extended to test this case as well?
>>
> AFAIK, currently there is no test for 'cgo -cdefs'.
> (The reason I think is that 'cgo -cdefs' is only for bootstrap of package
> runtime,
> e.g., internal use only. IMHO, It probably should not even be mentioned in
> 'cgo -help',
> although the current help text for -cdefs is already:

Ah, no worries, then.

Ian

[mikio, 2012-01-23 19:35:51]

LGTM

leave it to rsc.

[rsc, 2012-01-23 19:44:05]

LGTM

[rsc, 2012-01-23 19:45:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=fff00f608958 ***

cgo: -cdefs should translate unsafe.Pointer to void *
        Fixes issue 2454.

R=rsc, mikioh.mikioh, golang-dev, iant, iant
CC=golang-dev
http://codereview.appspot.com/5557068

Committer: Russ Cox <rsc@golang.org>